docs: fix ragged list example in model intro to ensure rectangular shape#1212
Open
anmol52490 wants to merge 1 commit intohuggingface:mainfrom
Open
docs: fix ragged list example in model intro to ensure rectangular shape#1212anmol52490 wants to merge 1 commit intohuggingface:mainfrom
anmol52490 wants to merge 1 commit intohuggingface:mainfrom
Conversation
In the "Models" section of the documentation, the example regarding tensor conversion contained a logical error. It presented a list of two sequences with unequal lengths (16 and 8 tokens) while stating the structure was "already of rectangular shape." This would cause a ValueError when passed to torch.tensor(). This PR: - Updates the encoded_sequences example to include padding zeros for the second sequence. - Clarifies that the tokenization step assumes `padding=True` to achieve this shape. - Ensures the code snippets are functionally accurate for users copying them into a PyTorch environment.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Author
|
Hello, respective maintainer @julien-c or @thliang01. Please, do review and confirm this PR if the fix looks correct. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the "Models" section of the documentation, the example regarding tensor conversion contained a logical error. It presented a list of two sequences with unequal lengths (16 and 8 tokens) while stating the structure was "already of rectangular shape."
This would cause a ValueError when passed to torch.tensor().
This PR:
padding=Trueto achieve this shape.